Eugene.Zelenko added a comment. Will be good idea to make callers function list configurable through option. See other checks as example.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:20 +void SignalInMultithreadedProgramCheck::registerMatchers(MatchFinder *Finder) { + + auto signalCall = ---------------- Unnecessary empty line. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:112 ^^^^^^^^^^^^^^^^^ +- New alias :doc:`cert-con37-c + <clang-tidy/checks/cert-con37-c>` to ---------------- Please add empty line above. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-in-multithreaded-program.rst:12 + +.. code-block: c + ---------------- Should be double colon. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-in-multithreaded-program.rst:18 +This check corresponds to the CERT C++ Coding Standard rule +`CON37-C. Do not call signal() in a multithreaded program +<https://wiki.sei.cmu.edu/confluence/display/c/CON37-C.+Do+not+call+signal%28%29+in+a+multithreaded+program>`_. ---------------- Please enclose signal() in double back-ticks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits