cameron.mcinally accepted this revision.
cameron.mcinally added a comment.
This revision is now accepted and ready to land.
LGTM, with the TODO to be handled under a separate patch.
Thank you for taking care of this, Simon.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341
Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI);
// TODO: Remove the hack for the binop form when the unary op is optimized
// properly with all IR passes.
----------------
xbolva00 wrote:
> simoll wrote:
> > xbolva00 wrote:
> > > What about this TODO?
> > Ok. So this seems to be a hack to update the FSub idiom on the fly.
> > How about we get rid of the TODO and the code below in a separate patch?
> I agree
+1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75130/new/
https://reviews.llvm.org/D75130
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
