sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/ClangdServer.h:145
- /// Enable cross-file rename feature.
- bool CrossFileRename = false;
+ /// Options for rename.
+ RenameOptions RenameOpts;
----------------
rename is just a normal API call, why is this a server option rather than a
parameter to rename()?
It probably needs to be a member in ClangdLSPServer though, like
CodeCompleteOptions.
(WantFormat belongs in this struct, I think)
================
Comment at: clang-tools-extra/clangd/refactor/Rename.h:30
+struct RenameOptions {
+ bool AllowCrossFile = false;
+ /// The mamimum number of affected files (0 means no limit), only meaningful
----------------
This needs a comment.
Or combine with LimitFiles, so that 0 means no cross-file rename.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74834/new/
https://reviews.llvm.org/D74834
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
