bader marked an inline comment as done. bader added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:3419 +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group<sycl_Group>, Flags<[CC1Option, NoArgumentUnused, CoreOption]>, + HelpText<"SYCL language standard to compile for.">, Values<"2015, 121, 1.2.1, sycl-1.2.1">; ---------------- keryell wrote: > I suggest replacing all the 2015 by 2017. > While this is true SYCL 1.2 was published in 2015, SYCL 1.2.1 was published > in 2017. Only 1.2.1 matters here since 1.2 was never fully implemented by any > conformant implementation. https://en.wikipedia.org/wiki/SYCL Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
