On Tue, Feb 18, 2020 at 11:37 AM John Marshall <john.w.marsh...@glasgow.ac.uk> wrote: > > On 18 Feb 2020, at 16:24, Aaron Ballman <aa...@aaronballman.com> wrote: > > > > I've commit on your behalf in > > 260b91f379c8f86d3d6008648b3f2a945a007888, thank you for the patch! > > Thanks very much, Aaron. > > I regret to report that this appears to have broken an additional test [1] > that I didn't see when running the test suite locally with "make > check-clang". Patch (untested) attached.
Yup, I saw the failure on IRC and pushed up a change in 66c01627719f088bff9a0d09655a8ca0842b2c82 that should resolve it -- we fixed the issue the same way. ~Aaron > > John > > [1] > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/23835/steps/test-check-all/logs/stdio > > --- a/clang/bindings/python/tests/cindex/test_diagnostics.py > +++ b/clang/bindings/python/tests/cindex/test_diagnostics.py > @@ -100,7 +100,7 @@ class TestDiagnostics(unittest.TestCase): > self.assertRegexpMatches(children[0].spelling, > '.*declared here') > self.assertEqual(children[0].location.line, 1) > - self.assertEqual(children[0].location.column, 1) > + self.assertEqual(children[0].location.column, 6) > > def test_diagnostic_string_repr(self): > tu = get_tu('struct MissingSemicolon{}') > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
