hokein added inline comments. ================ Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:80 @@ +79,3 @@ + UsedByRef() || + !ast_matchers::match(cxxMethodDecl(isOverride()), *Function, + *Result.Context) ---------------- alexfh wrote: > I meant, you can use it inside `UsedByRef`. Looks like we can't make it in `UsedByRef`.
The `ast_matchers::match` argument passed in `UsedByRef` is a `TranslationUnitDecl` type, which isn't used to match `CXXMethodDecl`. the code below is always true: ``` ast_matchers::match( cxxMethodDecl(isOverride()), *Result.Context->getTranslationUnitDecl(), *Result.Context).empty() ``` http://reviews.llvm.org/D17926 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits