aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D16529#366433, @LegalizeAdulthood wrote:

> Squeak.  This has been waiting on review for over two weeks....


Sorry for the delay, I was at WG21 meetings last week, so code reviews mostly 
were ignored by me.

I think this check LGTM, but please wait for @alexfh before committing.


================
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:82
@@ +81,3 @@
+                        ? std::string{R"lit()")lit"}
+                        : (")" + Delimiter + R"(")")) != StringRef::npos;
+}
----------------
This is a wonderful demonstration of why I hate raw string literals on shorter 
strings. I had to stare at that raw string for quite some time to figure it 
out. :-(


http://reviews.llvm.org/D16529



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to