rnk added inline comments.
================
Comment at: clang/include/clang/Driver/Job.h:59
/// Whether to print the input filenames when executing.
bool PrintInputFilenames = false;
----------------
Pack a new field after an existing bool for maximum micro optimization. :)
================
Comment at: clang/include/clang/Driver/Job.h:135
+ /// Whether the command will be executed in this process or not.
+ virtual bool inProcess() const { return false; }
+
----------------
I guess I lean towards making this a field, default initialized to false, set
to true in the CC1Command constructor. Less relocations, etc.
================
Comment at: clang/lib/Driver/Driver.cpp:3759
+ if (!Jobs.empty()) {
+ Command &Last = *llvm::reverse(Jobs).begin();
+ for (auto &Job : Jobs) {
----------------
`*std::prev(Jobs.end())`? Or `*Jobs.getJobs().back()`, not quite sure.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74447/new/
https://reviews.llvm.org/D74447
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
