rupprecht added a comment.
In D74433#1870647 <https://reviews.llvm.org/D74433#1870647>, @MaskRay wrote:
> Wait. I wonder whether we can change llvm-readobj to use lower case names as
> well. The following should be updated:
>
> StringRef ELFObjectFile<ELFT>::getFileFormatName() const {
> bool IsLittleEndian = ELFT::TargetEndianness == support::little;
> switch (EF.getHeader()->e_ident[ELF::EI_CLASS]) {
> case ELF::ELFCLASS32:
> switch (EF.getHeader()->e_machine) {
> case ELF::EM_386:
> return "ELF32-i386";
> case ELF::EM_IAMCU:
> return "ELF32-iamcu";
> case ELF::EM_X86_64:
> return "ELF32-x86-64";
> case ELF::EM_ARM:
>
>
> These are almost bfdnames, except that they use upper cases. I don't find a
> compelling argument using upper case `ELF`, so I vote for changing these
> `ELF` to `elf`. @jhenderson @grimar @sbc100 thoughts?
>
> // lib/Object/WasmObjectFile.cpp
> StringRef WasmObjectFile::getFileFormatName() const { return "WASM"; }
>
Yep... I was originally thinking we could update those to be lowercase, but
that's kinda a broader change, and I imagine most llvm developers are used to
seeing "ELF64-..." and I'm not sure it's worth changing all the tools just so
that objdump can be more GNU compatible.
I personally wouldn't mind it. If others are in favor of it too, I'm all for it
and can make the change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74433/new/
https://reviews.llvm.org/D74433
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
