Author: Haojian Wu Date: 2020-02-11T09:27:00+01:00 New Revision: 487621237d2fe5a53ac40a29f6443d3e4f106c61
URL: https://github.com/llvm/llvm-project/commit/487621237d2fe5a53ac40a29f6443d3e4f106c61 DIFF: https://github.com/llvm/llvm-project/commit/487621237d2fe5a53ac40a29f6443d3e4f106c61.diff LOG: [clangd] Remove a FIXME which has been done, NFC. Added: Modified: clang-tools-extra/clangd/refactor/Rename.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/refactor/Rename.cpp b/clang-tools-extra/clangd/refactor/Rename.cpp index 44ebdbce628d..9946dfe65ec8 100644 --- a/clang-tools-extra/clangd/refactor/Rename.cpp +++ b/clang-tools-extra/clangd/refactor/Rename.cpp @@ -352,9 +352,6 @@ findOccurrencesOutsideFile(const NamedDecl &RenameDecl, // index (background index) is relatively stale. We choose the dirty buffers // as the file content we rename on, and fallback to file content on disk if // there is no dirty buffer. -// -// FIXME: Our index may return implicit references, which are not eligible for -// rename, we should filter out these references. llvm::Expected<FileEdits> renameOutsideFile( const NamedDecl &RenameDecl, llvm::StringRef MainFilePath, llvm::StringRef NewName, const SymbolIndex &Index, _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
