hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good, thanks.
================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:309
return;
+ if ((R.Kind & RefKind::Spelled) == RefKind::Unknown)
+ return;
----------------
nit: I'd use ` if (!static_cast<int>(R.Kind & RefKind::Spelled))`.
================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:896
+ {
+ // Implicit references in macro expansions.
+ R"cpp(
----------------
nit: "only rename spelled references"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74112/new/
https://reviews.llvm.org/D74112
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
