kimgr added a comment.
A small Python suggestion.
================
Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:112
+
+ if "Notes" in diag:
+ for note in diag["Notes"]:
----------------
This double lookup is unnecessary, you can do `for note in diag.get("Notes",
[]):` to default to empty list if "Notes" is not in diag.
================
Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:114
+ for note in diag["Notes"]:
+ if "Replacements" in note and note["Replacements"]:
+ return True
----------------
Same here (not sure if Replacements holds a list, but I think it might)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72730/new/
https://reviews.llvm.org/D72730
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
