[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

[Michał Górny via Phabricator via cfe-commits]

mgorny added inline comments.


================
Comment at: clang/tools/clang-shlib/CMakeLists.txt:28
+    foreach(lib ${interface})
+      string(REGEX MATCH "^clang" is_clang_lib ${lib})
+      if (NOT is_clang_lib)
----------------
Any reason not to use `if(${lib} MATCHES ...)`?

https://cmake.org/cmake/help/v3.0/command/if.html

Not sure if `${}` is needed, I get always confused by that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68520/new/

https://reviews.llvm.org/D68520



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits