hans added inline comments.

================
Comment at: clang/test/Driver/Wp-args.c:27
+
+// RSP: inception
----------------
aganea wrote:
> hans wrote:
> > Why inception? I feel like I'm missing something :)
> Could be anything else :) Because `-rewrite-macros` prints this .c with 
> comments, and then FileCheck looks for that tag in stdout.
Ah, I see.

Do you think it would be possible to do something simpler, like just pass a -D 
flag and check that it gets set? That would be easier for future readers of the 
test to understand.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73120/new/

https://reviews.llvm.org/D73120



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to