jkorous added inline comments.
================ Comment at: clang/test/Frontend/verify-any-file.c:1 +// RUN: %clang_cc1 -verify %s 2>&1 + ---------------- I feel that we should test the output with FileCheck to make it more robust. Seems like other tests for `-verify` do that. For example here: https://github.com/llvm/llvm-project/blob/master/clang/test/Frontend/verify-fatal.c ================ Comment at: clang/test/Frontend/verify-any-file.c:6 +#include "verify-any-file.h" +// expected-error@*:* {{unknown type name 'unexpected'}} ---------------- Can we add some scenarios for expected diagnostics not produced? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
