fghanim marked an inline comment as done and an inline comment as not done.
fghanim added a comment.
Thanks for reviewing this.
After I address the last two comments below, How do I merge with llvm using
phab? I'd appreciate an llvm specific link if possible.
================
Comment at: llvm/lib/Frontend/OpenMP/OMPConstants.cpp:45
///{
-
#define OMP_TYPE(VarName, InitValue) Type *llvm::omp::types::VarName = nullptr;
----------------
jdoerfert wrote:
> Leftover
what is this referring to?
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:749
+ BasicBlock *ExitPredBB = SplitPos->getParent();
+ auto InsertBB = merged ? ExitPredBB : ExitBB;
+ if (!isa_and_nonnull<BranchInst>(SplitPos))
----------------
jdoerfert wrote:
> I have the feeling the merging makes it harder without providing a benefit
> but I'm OK with it for now
more difficult in what way?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72304/new/
https://reviews.llvm.org/D72304
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
