Thanks for reviewing this. The new constructor is to avoid initializing the "OS" field (which is not used by the empty BackendConsumer. Setting this field will affect the output). I will add a comment there.
-Rong On Mon, Jan 13, 2020 at 4:50 PM Teresa Johnson via Phabricator < revi...@reviews.llvm.org> wrote: > tejohnson accepted this revision. > tejohnson added a comment. > This revision is now accepted and ready to land. > > LGTM. One more request for a comment below that I forgot to add earlier. > > > > ================ > Comment at: clang/lib/CodeGen/CodeGenAction.cpp:154 > } > + BackendConsumer(BackendAction Action, DiagnosticsEngine &Diags, > + const HeaderSearchOptions &HeaderSearchOpts, > ---------------- > Add comment as to what specific case this new constructor is for. > > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D72523/new/ > > https://reviews.llvm.org/D72523 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
