MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2040
+ if (Value.getAsInteger(10, AlignBranchBoundary) ||
+ AlignBranchBoundary < 16 || !llvm::isPowerOf2_64(AlignBranchBoundary))
{
+ D.Diag(diag::err_drv_invalid_argument_to_option)
----------------
skan wrote:
> Any reason for precluding 16?
I did not preclude 16.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2053
+ << Value << A->getOption().getName();
+ AlignBranch = StringRef();
+ }
----------------
skan wrote:
> AlignBranch = StringRef() seems unnecessary.
This comment was for the previous diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72463/new/
https://reviews.llvm.org/D72463
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
