Eugene.Zelenko added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/cert/NotTrivialTypesLibcMemoryCallsCheck.cpp:51 + MatchFinder *Finder) { + using namespace ast_matchers::internal; + auto IsStructPointer = [](Matcher<CXXRecordDecl> Constraint = anything(), ---------------- Please add check for C++. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +- The 'bugprone-suspicous-constructor-and-assignment' check was renamed to :doc:`cert-not-trivial-types-libc-memory-calls + <clang-tidy/checks/cert-not-trivial-types-libc-memory-calls>` ---------------- Is this relevant? ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:114 + <clang-tidy/checks/cert-oop57-cpp>` check. + Checks for calls to memset, memcpy, memmove, strcpy, memcmp and strcmp on non + trivial types. ---------------- Please separate with empty line and synchronize with first statement in documentation. Please highlight memset, memcpy, memmove, strcpy, memcmp and strcmp with double back-ticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits