sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/FormattedString.cpp:156
+// indented.
+std::string indentLines(llvm::StringRef Input) {
+ std::string IndentedR;
----------------
assert that there's no trailing newlines?
================
Comment at: clang-tools-extra/clangd/FormattedString.h:75
+private:
+ std::vector<class Document> Documents;
+};
----------------
"items" rather than "documents" would capture the semantics better I think
================
Comment at: clang-tools-extra/clangd/FormattedString.h:92
+
std::string asMarkdown() const;
std::string asPlainText() const;
----------------
can we document that it *doesn't* render its own trailing newlines? This is a
divergence from Block and more important to the implementation now
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71422/new/
https://reviews.llvm.org/D71422
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
