sfantao added inline comments.

================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4002
@@ +4001,3 @@
+static llvm::Value *
+emitNumTeamsClauseForTargetDirective(CodeGenFunction &CGF,
+                                     const OMPExecutableDirective &D,
----------------
ABataev wrote:
> I still don't like the generation of some functions, that, generally 
> speaking, are not required.
> Could you try to add a new 'class CGOpenMPInlinedRegionInfo' like class, that 
> will be able to handle not captured variables in expressions?
Ok. In the the new diff I am using the logic for emission of inlined regions 
for num teams and thread limit as well. I still had to add extra logic in 
CodeGenFunction to insert extra entries in the local declaration cache, given 
that, as I discussed above, target regions make captured global variables 
local.  Hope this is aligned with what you have in mind.

Thanks! 


http://reviews.llvm.org/D17019



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to