dblaikie added a comment. In D71026#1785025 <https://reviews.llvm.org/D71026#1785025>, @arichardson wrote:
> If I build on macOS with `cmake -GNinja -DBUILD_SHARED_LIBS=ON > -DCMAKE_BUILD_TYPE=Debug > -DLLVM_ENABLE_PROJECTS=llvm;clang;lld;compiler-rt;libcxx;libcxxabi > -DBUILD_SHARED_LIBS=ON -DLLVM_ENABLE_MODULES=ON`, I get lots of linker errors > building e.g. libclangASTDiff.dylib due to using the internal ASTMatchers > header inside the Tooling/Transformer headers. > > This is probably due to https://bugs.llvm.org/show_bug.cgi?id=23521 mentioned > in the previous commits that added the exclude directives. Could we instead workaround this by adhering to the LLVM style guide's "requirement" (it's clearly not universally applied) have strong vtables? https://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers that way this would come up less often, by the sounds of it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71026/new/ https://reviews.llvm.org/D71026 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
