aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from some `auto` -> `auto *` nits. ================ Comment at: clang-tools-extra/clang-query/QueryParser.cpp:243-244 - return new LetQuery(Name, Value); + auto Q = new LetQuery(Name, Value); + Q->RemainingContent = Line; + return Q; ---------------- steveire wrote: > aaron.ballman wrote: > > Would it make more sense to have `Query` with another constructor to hold > > the remaining content, and then thread that through `LetQuery`, > > `MatchQuery`, etc? Whether there is remaining content or not seems like a > > pretty important property of the query, so it seems reasonable to let > > people construct with that information rather than set it after the fact. > > > > If not, these should be `auto *` rather than deducing the pointer. > I think it is set after the fact because it is set in `endQuery()`. Okay, that's reasonable. Thanks! Can you switch to `auto *` for these cases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71842/new/ https://reviews.llvm.org/D71842 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
