nridge marked an inline comment as done. nridge added inline comments.
================ Comment at: clang-tools-extra/clangd/FindTarget.cpp:116 + // smart pointer type. + ASTContext *Ctx = hackyFindASTContext(T); + if (!Ctx) ---------------- I don't intend for this function to be in the final patch. Rather, I'm wondering: am I missing some obvious general way to recover the `ASTContext` from a `Type` (or a `Stmt`)? If not, I think we'll need to modify `targetDecl()`, `allTargetDecls()`, `findExplicitReferences()` etc. to have their callers pass in an `ASTContext`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71644/new/ https://reviews.llvm.org/D71644 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
