serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:392 + EstimateSizeFormatHandler H(StrE); + StringRef StrRef = StrE->getString(); + const char *Str = StrRef.data(); ---------------- serge-sans-paille wrote: > erik.pilkington wrote: > > Will this assert on: `sprintf(buf, L"foo");`? Not that that makes any > > sense, but we shouldn't crash. > Still need to check that. Checked and fixed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
