kadircet marked 3 inline comments as done.
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/Hover.cpp:353
/// Generate a \p Hover object given the type \p T.
HoverInfo getHoverContents(QualType T, const Decl *D, ASTContext &ASTCtx,
+ const SymbolIndex *Index) {
----------------
ilya-biryukov wrote:
> kadircet wrote:
> > ilya-biryukov wrote:
> > > Not related to this patch, but what is `D` here? Is this getting hover
> > > contents for a type or for a decl?
> > it represents the deduced decl for Type, if any.
> What is a "deduced decl for Type"?
it was referring to the tagdecl referred by `decltype`s, i am not sure if there
are cases in which this can be different than `T->getAsTagDecl`.
Always making use of `T->getAsTagDecl` doesn't seem to be causing any test
failures.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71543/new/
https://reviews.llvm.org/D71543
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
