rnk added inline comments.
================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2519-2520
return VarLinkage;
+ // On Windows, WeakODR is a no-op, boiling down to the same as normal
external
+ // linkage.
+ if (CGM.getTriple().isOSWindows())
----------------
I would say that this is inaccurate. It greatly affects what the optimizer is
allowed to do.
It looks like we forgot to put a comdat on these things, is that not the
correct fix?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71572/new/
https://reviews.llvm.org/D71572
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
