simon_tatham added inline comments.
================
Comment at: clang/include/clang/Basic/arm_mve_defs.td:281
+// Scalar.
+def DblVector: VecOf<ComplexType<(CTO_DoubleSize Scalar)>>;
+
----------------
This could just be `VecOf<DoubleSize<Scalar>>`, after you carefully defined
`DoubleSize` above.
================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:3599
-class MVE_VMULL<string iname, string suffix, bit bit_28, bits<2> bits_21_20,
+class MVE_VMULL<string iname, string suffix, bit U, bits<2> size,
bit T, string cstr, list<dag> pattern=[]>
----------------
As I remember, the reason I //didn't// call these bits `U` and `size` was
because that's not what they mean in all situations – as the comment below
mentions, for polynomial multiplies, the size is encoded in the bit you've now
called `U`.
I know `bit_28` and `bits_21_20` are cumbersome and annoying names, but I think
that's still better than being inaccurate :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71066/new/
https://reviews.llvm.org/D71066
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
