pcc marked an inline comment as done.
pcc added inline comments.
================
Comment at: clang/test/Driver/android-no-installed-libcxx.cpp:8
+// RUN: -stdlib=libc++ -fsyntax-only %s -### 2>&1 | FileCheck %s
+// CHECK-NOT: "-internal-isystem" "{{.*}}v1"
----------------
danalbert wrote:
> This looks like it should be failing. The NDK headers are installed to
> `<NDK>/sysroot/usr/include/c++/v1`. Presumably it's passing because the
> trivial sysroot in the test directory is not complete enough?
>
> Will need a more specific CHECK-NOT here, and also a CHECK to make sure the
> correct directory is being searched.
The `%t/include/c++/v1` path here represents the install directory, not the
sysroot. Note that the test isn't passing a `-sysroot` flag.
We already have a test that the correct directory is being searched, see
`test/Driver/android-ndk-standalone.cpp`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71154/new/
https://reviews.llvm.org/D71154
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
