NoQ added a comment.

I've been hiding these internal traits in ExprEngine lately but i don't have a 
strong preference. I don't see any immediate need to expose this info to the 
checkers, nor do i see a need to actively hide it.

And, yeah, needs dead region cleanup :)



================
Comment at: clang/lib/StaticAnalyzer/Core/ProgramState.cpp:229-233
+    for (const MemRegion *R : Invalidated) {
+      if (!R->hasStackStorage())
+        continue;
+      newState = newState->add<EscapedLocals>(R);
+    }
----------------
Ok, so how do we want to deal with non-base regions? I think for the purposes 
of escaping we try to stick to per-base-region granularity (cf. the C-style 
linked list example). This is also going to be nice because the amount of 
regions we'll have to track is going to be more limited and there's going to be 
no problem of representing the same region in multiple different ways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71152/new/

https://reviews.llvm.org/D71152



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to