jdoerfert added a comment.
Thx for this patch. Only two minor comments.
================
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230
- "unknown '%0' device kind trait in the 'device' context selector set,
expected"
- " one of 'host', 'nohost', 'cpu', 'gpu' or 'fpga'">;
----------------
I would have expected this error to be still accurate, maybe with the addition
", or quoted versions thereof".
================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:424
+ if (ER.isUsable())
+ Values.push_back(ER);
}
----------------
When would ER not be usable here? Is there a valid use case or should we assert
it is?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70973/new/
https://reviews.llvm.org/D70973
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
