rnk added a subscriber: rsmith. rnk added a comment. Changes seem fine to me, FWIW. +@rsmith
================ Comment at: clang/test/Analysis/uninit-asm-goto.cpp:10 + return -1; +} ---------------- This could use a test for the case where an input is uninitialized, and where an uninitialized value is used along the error path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits