kpn added inline comments.
================
Comment at: llvm/include/llvm/IR/IRBuilder.h:268
I->addAttribute(AttributeList::FunctionIndex, Attribute::StrictFP);
- setConstrainedFPFunctionAttr();
}
----------------
mibintc wrote:
> @kpn I got rid of this line because the function attribute is being set in
> CodeGen
Makes sense.
================
Comment at: llvm/unittests/IR/IRBuilderTest.cpp:186
Builder.setIsFPConstrained(true);
+ auto Parent = BB->getParent();
+ Parent->addFnAttr(Attribute::StrictFP);
----------------
mibintc wrote:
> @kpn I changed the test to create the function attribute a priori since it
> will be set in CodeGen before passing to IRBuilder
Right, of course.
I'm not going to quibble over the use of auto. It's fine I think.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62731/new/
https://reviews.llvm.org/D62731
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
