hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
sorry for the delay, looks good, one more nit. ================ Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:91 { scheme: 'file', language: 'cpp' }, + // Syntax highlighting for the 'cuda' language is + // provided by the kriegalex.vscode-cudacpp plugin. ---------------- This comment seems not correct anymore, I'd just drop it, or rephrase like `VSCode does not have CUDA as a supported language yet, but our extension does`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70041/new/ https://reviews.llvm.org/D70041 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits