aganea added inline comments.
================
Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:419
+ * the open file object \p File. */
+static int writeProfileWithFileObject(const char *Filename, FILE *File) {
+ setProfileFile(File);
----------------
These two functions are not used when targeting Windows, do you think it'll be
possible to `#ifdef` them out in a follow up patch? Thanks in advance!
```
[550/4755] Building C object
projects\compiler-rt\lib\profile\CMakeFiles\clang_rt.profile-x86_64.dir\InstrProfilingFile.c.obj
F:\llvm-project\compiler-rt\lib\profile\InstrProfilingFile.c(419,12): warning:
unused function 'writeProfileWithFileObject' [-Wunused-function]
static int writeProfileWithFileObject(const char *Filename, FILE *File) {
^
F:\llvm-project\compiler-rt\lib\profile\InstrProfilingFile.c(429,13): warning:
unused function 'unlockProfile' [-Wunused-function]
static void unlockProfile(int *ProfileRequiresUnlock, FILE *File) {
^
2 warnings generated.
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69586/new/
https://reviews.llvm.org/D69586
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
