kpn added a comment.
Does anyone think a warning is appropriate because the new flags are exercising
experimental, incomplete code in both clang and llvm? The warning would be
removed when we believe the feature is complete and ready to use.
================
Comment at: llvm/include/llvm/IR/IRBuilder.h:262
Function *F = BB->getParent();
- if (!F->hasFnAttribute(Attribute::StrictFP)) {
+ if (F && !F->hasFnAttribute(Attribute::StrictFP)) {
F->addFnAttr(Attribute::StrictFP);
----------------
This looks reasonable to me.
It smells like there's a larger strictfp IRBuilder issue, but that's not an
issue for this patch here. The larger issue won't be hit since the new options
affect the entire compilation. It therefore shouldn't block this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62731/new/
https://reviews.llvm.org/D62731
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
