xiangzhangllvm added inline comments.
================ Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:134 + /// macro-fusion. + inline FirstMFInstKind classifyFirstOpcode(unsigned Opcode) { + switch (Opcode) { ---------------- xiangzhangllvm wrote: > We rarely put function definition at *.h, if putting it into > X86MacroFusion.cpp will cause compile problem, X86AsmBackend.cpp maybe a good > place to put it. Seems not big function, just many "case", it is fine for me if you don't want to change it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits