aaron.ballman added a comment. In D67460#1739062 <https://reviews.llvm.org/D67460#1739062>, @poelmanc wrote:
> Thanks @aaron.ballman, I don't have commit access so will someone else commit > this? I can commit it for you when I get back into the office mid-next week, unless someone else wants to commit it on your behalf first. > To address the minor nit, should I upload a new patch with > post-increment/post-decrement changed to pre-increment/pre-decrement? (Does > uploading changes undo the "Ready to Land" status?) Yes, please upload a new patch. It may change the review state in Phab, but unless it's a substantive change (which this is not), we do not require additional review/acceptance before landing (unless someone clicks the "Request Changes" option in the meantime). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67460/new/ https://reviews.llvm.org/D67460 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
