ABataev added inline comments.

================
Comment at: clang/test/OpenMP/barrier_codegen.cpp:22
+// CLANGCG-NOT: readonly
+// IRBUILDER:      ; Function Attrs: nofree nosync nounwind readonly
+// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_num(%struct.ident_t*)
----------------
Not sure about correct use of `nosync` and `readonly` attributes. OpenMP 
runtime uses lazy initialization of the runtime library and when any runtime 
function is called, the inner parts of the OpenMP runtime are initialized 
automatically. It may use some sync primitives and may modify memory, I assume. 
Same about `nofree`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69922/new/

https://reviews.llvm.org/D69922



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to