efriedma added inline comments.
Herald added a subscriber: sameer.abuasal.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:498
+ CmdArgs.push_back(
+ Args.MakeArgString(Twine("-plugin-opt=-target-abi=") + ABIName));
}
----------------
I don't think this change is right. In general, target features should be
encoded in bitcode files. This allows compiling different files with different
target features, and using runtime detection to only run certain codepaths.
And it makes sure that we end up with a sane result if the user doesn't pass
target feature flags on the link line.
Also, it probably isn't appropriate to make target-independent changes in a
commit tagged [RISCV]; most people would assume a change marked like that
doesn't have target-independent effects.
(Sorry about the delayed response to this review; I only just ran into this.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67409/new/
https://reviews.llvm.org/D67409
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
