probinson added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6171
+
+ if (DwarfVersion == 0)
+ DwarfVersion = ParseDwarfDefaultVersion(getToolChain(), Args);
----------------
MaskRay wrote:
> lang=cpp
> if (DwarfVersion == 0) {
> DwarfVersion = ParseDwarfDefaultVersion(getToolChain(), Args);
> if (DwarfVersion == 0)
> DwarfVersion = getToolChain().GetDefaultDwarfVersion();
> }
>
> This part constructs a -cc1as command line. It is not covered by a test. Can
> you add one?
Hi @MaskRay , your version would have the unclaimed-option problem.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69822/new/
https://reviews.llvm.org/D69822
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
