rnk added a comment.

> I think a better distinguisher would be whether clang was invoked as 
> clang[++] or clang-cl (i.e. driver mode).

I think Martin said most of what I wanted to say. Making this dependent on the 
driver mode seems reasonable and would be the easier way forward.

If you still want to make `clang-cl -fuse-ld=lld` call `ld.lld` with gnu-style 
flags, you will need to pre-fix the various in-tree test suites. If you look 
through the LLDB, compiler-rt, and debuginfo-tests test suites, you will see 
many instances of `-fuse-ld=lld` that rely on the current behavior. See cases 
like:
https://github.com/llvm/llvm-project/blob/dd0c00b5f8b303f78565ab407d37a643e99a9e75/compiler-rt/test/asan/lit.cfg.py#L96
Maybe that case in particular doesn't apply, but it needs to be looked into.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69760/new/

https://reviews.llvm.org/D69760



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to