thakis added a comment.

Thanks for sending this out!

Instead of the dynamic lookup of that symbol, what do you think about passing 
in the function via a normal api? That way, the type checker and linker help us 
keep things working; dynamic lookup is always a bit subtle and hard to grep 
for. (llvm-cs wouldn't know about the current use, for example.) See 
https://reviews.llvm.org/D69848 for a rough sketch.

For robust crash handling, I figured on non-win we'd have a signal handler that 
on signal self-execs with a "actually, do use a cc1 process" and then use the 
existing crash machinery, but maybe that's not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69825/new/

https://reviews.llvm.org/D69825



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to