NoQ added a comment. In D69308#1727108 <https://reviews.llvm.org/D69308#1727108>, @Szelethus wrote:
> Would love to see this comment in its entirety on the open projects page :^) I'd rather have a mention that @dkrupp is already working on this project, so that if somebody wanted to help out they could cooperate nicely. ================ Comment at: clang/test/Analysis/clangsa_unsupported_features/handle_constructors_for_default_arguments.cpp:3-6 +// REQUIRES: non-existing-system + +// These test cases demonstrate lack of Static Analyzer features. +// Remove REQUIRES line, when the feature gets implemented. ---------------- NoQ wrote: > I prefer our FIXME-tests to keep running while documenting incorrect results, > so that people were informed when they fix something. Eg.: > > ```lang=c++ > // FIXME: Should be TRUE. > clang_analyzer_eval(x); // expected-warning{{UNKNOWN}} > ``` > > I doubt that the whole file of tests will be fixed by a single commit, so > they'll have to change this anyway. > > It's also nice to inform people that they accidentally changed something they > didn't expect to change. Also let's not put it to "unsupported_features" so that we didn't have to move it (and lose history / or forget to move) later. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69308/new/ https://reviews.llvm.org/D69308 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits