thakis added a comment.

In D63607#1727037 <https://reviews.llvm.org/D63607#1727037>, @peterwaller-arm 
wrote:

> Thanks for chiming in.
>
> > Sorry, I had missed the RfC, but it looks like there wasn't a lot of 
> > discussion on it anyways.
>
> Apologies @thakis - did I jump the gun? And if so, what could I have done 
> differently?


Whoops, sorry! I had meant to delete that bit. I started writing that, then 
went back to the old discussion thread, and saw that there was actually 
agreement on giving clang's driver knowledge about fortran (but not the 
preprocessor etc). So this is all good as far as I can tell. Please ignore that 
part.

The test is still failing fairly consistently on my bot, even after 6c0a160c 
<https://reviews.llvm.org/rG6c0a160c2d33e54aecf1538bf7c85d8da92051be> . (And 
that change required me to change my bots from `git merge --ff-only 
origin/master` to `git reset --hard origin/master` after fetching, but that's a 
good change to do anyways ;) ). Does http://45.33.8.238/mac/2528/step_6.txt 
make any sense to you, or should I ssh in and debug?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63607/new/

https://reviews.llvm.org/D63607



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to