ABataev added inline comments.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14450
+ if (HasMeetPointer && !IsLastArraySection) {
+ SemaRef.Diag(ELoc, diag::err_omp_pointer_type_not_last)
----------------
Ad the check for the version of OpenMP standard, it must be allowed only for
OpenMP >= 50.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14470
AllowWholeSizeArraySection = false;
- } else if (AllowUnitySizeArraySection && NotUnity) {
+ } else if (DKind != OMPD_target_update &&
+ (AllowUnitySizeArraySection && NotUnity)) {
----------------
Same here, allow only for OpenMP >= 50. Also, split the patch into 2 parts, one
for pointers stuff and another one for target update directive.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69316/new/
https://reviews.llvm.org/D69316
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
