ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1466
Output.Completions.back().Score = C.second;
Output.Completions.back().CompletionTokenRange = ReplacedRange;
}
----------------
kadircet wrote:
> why not handle `SnippetSuffix` in here ?
>
> instead of propagating `IsUsingDeclaration`, we can just drop
> `Output.Completions.back().SnippetSuffix` in here, which sounds like a more
> appropriate layering.
> considering we don't really have context specific knowledge in
> `CodeCompletionBuilder` ?
I was trying to keep all processing of snippets in one place.
Code completion code is hard enough to navigate as it stands today...
Although I agree doing this when summarizing items in a bundles looks like the
wrong layer, but this place is also after bundling, so I'm not sure if it's
actually winning us much.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69382/new/
https://reviews.llvm.org/D69382
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
