hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land.
In D63607#1709258 <https://reviews.llvm.org/D63607#1709258>, @peterwaller-arm wrote: > Friendly ping to everybody watching. I'd like to get this in soon if possible. > > Hal - do you think this is close to being accepted? Note that I consider this > "the beginning" rather than "the end", since there will be more functionality > to add piecewise before this is fully functional. In the meantime, since it > is new functionality, it should not break anything. One comment on the test, but otherwise LGTM. ================ Comment at: clang/test/Driver/flang/flang-not-installed.f90:11 +! shell syntax. +! UNSUPPORTED: windows + ---------------- I believe that you can write: REQUIRES: shell for this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
