gribozavr added a comment.

What are the use cases for non-text values?

I like the name `text` much better... If the name conflict is the issue, I 
think you could rename it to `toText` -- it would even read more fluently 
`change(toText("abc"))`, also making it obvious that we are not changing *the 
text abc*, but we are changing the code to say "abc".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69184/new/

https://reviews.llvm.org/D69184



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to