NoQ marked an inline comment as done.
NoQ added inline comments.

================
Comment at: clang/test/Analysis/dump_egraph.c:46
 
 // CHECK: \"pretty\": \"*x\", \"location\": \{ \"line\": 18, \"column\": 10, 
\"file\": \"{{(.+)}}dump_egraph.c\" \}
 
----------------
Charusso wrote:
> `\"file\": \"{{(.+)}}dump_egraph.c\" \}` is a cool workaround, but otherwise 
> if you do not want to end line 32, could you remove this line's ending please?
Interestingly, this doesn't work in my case but does work in this older case, 
due to greediness: the first `{(.+)}}dump_egraph.c` matches everything until 
the second `dump_egraph.c` and then it can't find the `PreStmtPurgeDeadSymbols` 
line after it because it was already skipped.

I tried to make it non-greedy: `{{(.+?)}}dump_egraph.c` but it says it's not 
allowed.

I'm pretty bad with regexps so i decided to screw it :) But let's keep at least 
this test in order to test that the filename is actually printed.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69150/new/

https://reviews.llvm.org/D69150



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to